This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix logging config for the docker image #6197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out that loggers that are instantiated before the config is loaded get turned off. Also bring the logging config that is generated by --generate-config into line. Fixes #6194.
richvdh
force-pushed
the
rav/fix_logging
branch
from
ad48b0c to
08f5f23
Compare
erikjohnston
approved these changes
Oct 18, 2019
| @@ -68,9 +68,6 @@ | |||
| filters: [context] | |||
|
|
|||
| loggers: | |||
| synapse: | |||
| level: INFO | |||
|
|
|||
There was a problem hiding this comment.
Why remove this and not the synapse.storage.SQL below? It feels nice to give a place to easily up the synapse log level?
There was a problem hiding this comment.
Do you think it's particularly likely that we would need to up the synapse log level and not other loggers? ie, why wouldn't you do this in the root logger?
The separate config for synapse.storage.SQL exists so that if you set your logging to DEBUG (either at the root level, or just for synapse), you don't start logging all the access tokens etc that go in and out of the database.
1 task
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '560c12226': Fix logging config for the docker image (#6197)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that loggers that are instantiated before the config is loaded get
turned off.
Also bring the logging config that is generated by --generate-config into line.
Fixes #6194.