This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Rewrite the user_filter migration again #6184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
you can't plausibly ALTER TABLE in sqlite, so we create the new table with the right schema to start with.
erikjohnston
previously requested changes
Oct 9, 2019
| """ | ||
| else: | ||
| select_clause = """ | ||
| CREATE TEMPORARY TABLE user_filters_migration AS | ||
| SELECT * FROM user_filters GROUP BY user_id, filter_id; | ||
| SELECT * FROM user_filters GROUP BY user_id, filter_id | ||
| """ | ||
| sql = ( | ||
| """ | ||
| BEGIN; |
There was a problem hiding this comment.
I think we're already in a transaction? Which would mean that the END would commit everything in the current transaction, which is probably not what we want
There was a problem hiding this comment.
oh, hum. maybe? I don't think it's useful, anyway. will remove.
| """ | ||
| else: | ||
| select_clause = """ | ||
| CREATE TEMPORARY TABLE user_filters_migration AS | ||
| SELECT * FROM user_filters GROUP BY user_id, filter_id; | ||
| SELECT * FROM user_filters GROUP BY user_id, filter_id |
There was a problem hiding this comment.
Doesn't this work for both postgres and sqlite now?
There was a problem hiding this comment.
no, postgres complains because filter_json is neither in the group by nor explicitly aggregated. I considered futzing around with something to pick an arbitrary filter_json from the results, but in the end decided to stick with pik's solution.
erikjohnston
approved these changes
Oct 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
you can't plausibly ALTER TABLE in sqlite, so we create the new table with the
right schema to start with.