This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Factor out backgroung updates #6178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
previously requested changes
Oct 8, 2019
erikjohnston
approved these changes
Oct 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the ongoing work on
synapse_port_db, factor out the background updates handlers and registration to dedicated stores so that a script can instantiate a subset of theDataStoreto only run them and not the whole thing, which would start other background processes we might not want to run.This PR doesn't include factoring out the
StatsStore, because doing so on this class is not trivial, and it doesn't register any looping call or background process (apart from background updates).