Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix appservice room list pagination #6154

Merged
merged 2 commits into from
Oct 2, 2019
Merged

Fix appservice room list pagination #6154

merged 2 commits into from
Oct 2, 2019

Conversation

erikjohnston
Copy link
Member

We need to add to query_args in the same order as the various clauses appear in the SQL.

@erikjohnston erikjohnston requested a review from a team October 2, 2019 14:48
richvdh
richvdh approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. tests would be nice.

@erikjohnston erikjohnston merged commit dca7e32 into develop Oct 2, 2019
@erikjohnston erikjohnston deleted the erikj/fix_appservice_pagination branch January 9, 2020 15:48
babolivier pushed a commit that referenced this pull request Sep 1, 2021
@anoadragon453
Merge pull request #6154 from matrix-org/erikj/fix_appservice_pagination
bebf756
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@richvdh richvdh richvdh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikjohnston @richvdh