Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Pin eliot to <1.8 on python 3.5.2 #5218

Merged
merged 3 commits into from
May 21, 2019
Merged

Pin eliot to <1.8 on python 3.5.2 #5218

merged 3 commits into from
May 21, 2019

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented May 21, 2019

Fixes #5199

@richvdh richvdh requested a review from a team May 21, 2019 11:11
@richvdh richvdh removed the request for review from a team May 21, 2019 11:51
@richvdh
Copy link
Member Author

richvdh commented May 21, 2019

well, that didn't go well

@codecov
Copy link

codecov bot commented May 21, 2019

Codecov Report

Merging #5218 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #5218      +/-   ##
===========================================
+ Coverage    62.48%   62.48%   +<.01%     
===========================================
  Files          338      338              
  Lines        35035    35035              
  Branches      5734     5734              
===========================================
+ Hits         21890    21893       +3     
+ Misses       11596    11594       -2     
+ Partials      1549     1548       -1

@codecov
Copy link

codecov bot commented May 21, 2019

Codecov Report

Merging #5218 into develop will increase coverage by <.01%.
The diff coverage is 90%.

@@             Coverage Diff             @@
##           develop    #5218      +/-   ##
===========================================
+ Coverage    62.48%   62.48%   +<.01%     
===========================================
  Files          338      338              
  Lines        35035    35040       +5     
  Branches      5734     5735       +1     
===========================================
+ Hits         21890    21895       +5     
- Misses       11596    11598       +2     
+ Partials      1549     1547       -2

@richvdh richvdh requested a review from a team May 21, 2019 12:57
Copy link
Contributor

@babolivier babolivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@richvdh richvdh merged commit bab3edd into develop May 21, 2019
@richvdh richvdh deleted the rav/pin_eliot branch May 21, 2019 14:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants