This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Block attempts to annotate the same event twice #5212
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #5212 +/- ##
===========================================
- Coverage 62.49% 61.82% -0.68%
===========================================
Files 338 338
Lines 35064 35048 -16
Branches 5738 5736 -2
===========================================
- Hits 21913 21668 -245
- Misses 11604 11800 +196
- Partials 1547 1580 +33 |
richvdh
approved these changes
May 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm otherwise
synapse/handlers/message.py
Outdated
@@ -601,6 +601,20 @@ def create_new_client_event(self, builder, requester=None, | |||
|
|||
self.validator.validate_new(event) | |||
|
|||
# We now check that if this event is an annotation that the can't |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
words no sense
richvdh
reviewed
May 21, 2019
changelog.d/5203.feature
Outdated
@@ -0,0 +1 @@ | |||
Add experimental support for relations (aka reactions and edits). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this lost?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did that happen
erikjohnston
force-pushed
the
erikj/deny_multiple_reactions
branch
from
May 21, 2019 16:05
ae95e56
to
44b8ba4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which means e.g. that a user can't like the same event more than once.