Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Block attempts to annotate the same event twice #5212

Merged
merged 3 commits into from
May 21, 2019

Conversation

erikjohnston
Copy link
Member

Which means e.g. that a user can't like the same event more than once.

@codecov
Copy link

codecov bot commented May 20, 2019

Codecov Report

Merging #5212 into develop will decrease coverage by 0.67%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #5212      +/-   ##
===========================================
- Coverage    62.49%   61.82%   -0.68%     
===========================================
  Files          338      338              
  Lines        35064    35048      -16     
  Branches      5738     5736       -2     
===========================================
- Hits         21913    21668     -245     
- Misses       11604    11800     +196     
- Partials      1547     1580      +33

@erikjohnston erikjohnston requested a review from a team May 21, 2019 12:15
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

@@ -601,6 +601,20 @@ def create_new_client_event(self, builder, requester=None,

self.validator.validate_new(event)

# We now check that if this event is an annotation that the can't
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

words no sense

@@ -0,0 +1 @@
Add experimental support for relations (aka reactions and edits).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this lost?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did that happen

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants