This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Only check 3pids not in use when registering #5187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We checked that 3pids were not already in use before we checked if we were going to return the account previously registered in the same UI auth session, in which case the 3pids will definitely be in use. element-hq/element-web#9586
Codecov Report
@@ Coverage Diff @@
## develop #5187 +/- ##
===========================================
- Coverage 62.15% 62.14% -0.01%
===========================================
Files 336 336
Lines 34659 34663 +4
Branches 5694 5696 +2
===========================================
+ Hits 21541 21542 +1
- Misses 11583 11585 +2
- Partials 1535 1536 +1 |
richvdh
suggested changes
May 15, 2019
changelog.d/5187.bugfix
Outdated
| @@ -0,0 +1 @@ | |||
| Fix register endpoint returning a previously registered account. | |||
There was a problem hiding this comment.
Could you expand this a bit? It seems to say that the bug was that the endpoint incorrectly returned a previously registered account, but I don't think that is the case.
There was a problem hiding this comment.
Yeah I don't know why I thought that was a sensible wording.
DMRobertson
deleted the
dbkr/only_check_threepid_not_in_use_if_actually_registering
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We checked that 3pids were not already in use before we checked if
we were going to return the account previously registered in the
same UI auth session, in which case the 3pids will definitely
be in use.
element-hq/element-web#9586