This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Allow client event serialization to be async #5183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
force-pushed
the
erikj/async_serialize_event
branch
from
6229801 to
b54b03f
Compare
erikjohnston
force-pushed
the
erikj/async_serialize_event
branch
from
d118342 to
a80e6b5
Compare
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## develop #5183 +/- ##
===========================================
+ Coverage 62.15% 62.16% +0.01%
===========================================
Files 336 336
Lines 34659 34686 +27
Branches 5694 5679 -15
===========================================
+ Hits 21541 21562 +21
- Misses 11583 11590 +7
+ Partials 1535 1534 -1 |
richvdh
approved these changes
May 15, 2019
Co-Authored-By: Richard van der Hoff <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for bundling in reactions