This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Move the admin API to /_synapse/admin/v1
#5119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't really belong under rest/client/v1 any more.
Codecov Report
@@ Coverage Diff @@
## develop #5119 +/- ##
===========================================
+ Coverage 61.65% 61.65% +<.01%
===========================================
Files 334 334
Lines 34523 34531 +8
Branches 5681 5682 +1
===========================================
+ Hits 21284 21290 +6
- Misses 11709 11711 +2
Partials 1530 1530 |
erikjohnston
approved these changes
May 2, 2019
spantaleev
added a commit
to devture/matrix-corporal
that referenced
this pull request
Sep 22, 2020
Switching from using `/_matrix/client/r0/admin/users/{userId}`
to using `/_synapse/admin/v2/users`.
Using Admin APIs from the /_matrix/client/r0/ prefix is more
and more deprecated and will stop working at some point.
For reference:
- matrix-org/synapse#5119
- https://github.com/matrix-org/synapse/releases/tag/v1.20.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4850. Note that the existing endpoints will still work, for now at least.
Note to the reviewer: There are three commits here, which are probably easier to review individually. The first tweaks the implementations so that they no longer depend on
ClientV1RestServlet, which is a bit of a solution looking for a problem anyway. The second commit adds the new prefix to the endpoints. The third commit moves the impl to a different package, since it was confusing to have it undersynapse.rest.client.v1.