Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Send out emails with links to extend an account's validity period #5047

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Send out emails with links to extend an account's validity period #5047

merged 1 commit into from
Apr 17, 2019

Conversation

babolivier
Copy link
Contributor

@babolivier babolivier commented Apr 11, 2019 •
edited
Loading

TODO:

  • Send mail to one user with a randomly-generated link
  • Loop over users who didn't get a mail yet and are expiring soon
  • Handle clicks on renewal link:
    • Push the expiration timestamp back
    • Invalidate the cache on get_expiration_ts_for_user

Follows #5027

@codecov
Copy link

codecov bot commented Apr 11, 2019 •
edited
Loading

Codecov Report

Merging #5047 into develop will decrease coverage by 1.47%.
The diff coverage is 38.46%.

@@             Coverage Diff             @@
##           develop    #5047      +/-   ##
===========================================
- Coverage    61.57%   60.09%   -1.48%     
===========================================
  Files          332      328       -4     
  Lines        34265    34132     -133     
  Branches      5648     5633      -15     
===========================================
- Hits         21097    20512     -585     
- Misses       11654    12161     +507     
+ Partials      1514     1459      -55

@codecov
Copy link

codecov bot commented Apr 15, 2019 •
edited
Loading

Codecov Report

Merging #5047 into develop will decrease coverage by 1.23%.
The diff coverage is 31.15%.

@@             Coverage Diff             @@
##           develop    #5047      +/-   ##
===========================================
- Coverage    61.57%   60.33%   -1.24%     
===========================================
  Files          332      330       -2     
  Lines        34265    34244      -21     
  Branches      5648     5640       -8     
===========================================
- Hits         21097    20660     -437     
- Misses       11654    12109     +455     
+ Partials      1514     1475      -39

@codecov-io
Copy link

codecov-io commented Apr 15, 2019 •
edited by codecov bot
Loading

Codecov Report

Merging #5047 into develop will decrease coverage by 1%.
The diff coverage is 83.33%.

@@             Coverage Diff             @@
##           develop    #5047      +/-   ##
===========================================
- Coverage    61.57%   60.56%   -1.01%     
===========================================
  Files          332      330       -2     
  Lines        34274    34271       -3     
  Branches      5652     5645       -7     
===========================================
- Hits         21103    20756     -347     
- Misses       11656    12036     +380     
+ Partials      1515     1479      -36

@babolivier babolivier marked this pull request as ready for review April 15, 2019 16:47
@babolivier babolivier requested a review from a team April 15, 2019 16:47
@babolivier
Copy link
Contributor Author

babolivier commented Apr 15, 2019 •
edited
Loading

Status ftr: Code is here and should be functional/reviewable, I'll add tests tomorrow.

The whole thing should be fairly well tested now.

erikjohnston
erikjohnston previously requested changes Apr 17, 2019
View reviewed changes
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few quibbles, but otherwise looks look good!

synapse/config/registration.py Outdated Show resolved Hide resolved
synapse/storage/schema/delta/54/account_validity.sql Show resolved Hide resolved
synapse/rest/client/v2_alpha/account_validity.py Outdated Show resolved Hide resolved
@babolivier babolivier requested a review from a team April 17, 2019 09:29
@babolivier babolivier requested a review from a team April 17, 2019 11:28
@babolivier babolivier force-pushed the babolivier/account_expiration branch from c954294 to 20f0617 Compare April 17, 2019 13:43
@babolivier babolivier merged commit 9193402 into develop Apr 17, 2019
@clokep clokep mentioned this pull request Sep 17, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erikjohnston erikjohnston erikjohnston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@babolivier @codecov-io @erikjohnston