Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

If you redact a tombstone you can't join the room any more. #5003

Closed
ara4n opened this issue Apr 3, 2019 · 7 comments
Closed

If you redact a tombstone you can't join the room any more. #5003

ara4n opened this issue Apr 3, 2019 · 7 comments
Assignees
Labels
A-Room-Upgrades z-bug (Deprecated Label) z-p2 (Deprecated Label)

Comments

@ara4n
Copy link
Member

ara4n commented Apr 3, 2019

says linda

@neilisfragile neilisfragile added A-Room-Upgrades z-p2 (Deprecated Label) labels Apr 5, 2019
@anoadragon453
Copy link
Member

anoadragon453 commented Apr 11, 2019

So from investigation I've found that redacting a tombstone in an upgraded room:

  • Still allows people who were in the old room to go back and look at it
  • In Riot web, removes the link in the "This room is no longer active" dialogue:

image

  • Makes it so users who aren't in the old room cannot view the new room (in Riot web). You click it in the room list and it highlights, but nothing else happens. Console logs:

image

  • If you invite the user to the old room they can join just fine, but they also have a broken upgrade message (no link to the new room)
  • Once the user is in the old room, they can switch to the new room just fine.

So we're looking at a few things here:

  • A bug in Riot web that allows the option to redact tombstone events
  • A bug in Synapse that allows you to redact tombstone events
  • A bug in Riot web that breaks it if the user joins a room with a predecessor room ID, but the referenced room does not have a tombstone event.

The link to the new room disappearing makes sense since that uses information stored in the tombstone.

@lampholder lampholder added the z-bug (Deprecated Label) label Apr 23, 2019
@anoadragon453 anoadragon453 self-assigned this Oct 30, 2019
@richvdh
Copy link
Member

richvdh commented Feb 5, 2020

I don't quite understand what the problem is here. What is the expected behaviour when redacting tombstone events?

@richvdh
Copy link
Member

richvdh commented Feb 26, 2020

if anyone can clarify, we can reopen.

@richvdh richvdh closed this as completed Feb 26, 2020
@altsalt
Copy link

altsalt commented Nov 23, 2021

I am currently seeking a way to revert a tombstone event and this was the closest issue I've yet found.

For background, I tried to upgrade a space by sending a post request to Synapse, however, it seems as though I can't join the new space and all matrix.to links re-direct to the old one.

I'm planning on deleting the space which was generated and resetting everything about the old space, but I don't want to do any of that until I can be sure that the tombstone event can be removed.

An empty m.room.tombstone event can't be sent, since tombstones require content. Also, the tombstone address can not be the same as the the room it is being sent to.

So to return to the question about "what is the expected behaviour" I'd expect the tombstone to be removed. However, to some of @anoadragon453 's points, is the ability to remove tombstones something that should be added to the spec or is it a bug to be able to do that at all?

Any direction towards fixes for my particular case would of course be appreciated as well!

@babolivier
Copy link
Contributor

@altsalt It sounds to me like a good first step would be asking in #synapse:matrix.org and see if the folks in there can't help you figure out if there's an easy way to fix your issue.

@altsalt
Copy link

altsalt commented Nov 24, 2021

Thanks @babolivier it appears that my particular issue comes down to poor handling of tombstones in spaces, which I can deal with rather than revert. That said, the larger question posed in this issue continues to seem relevant.

@anoadragon453
Copy link
Member

related: https://github.com/matrix-org/matrix-doc/issues/1937

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Room-Upgrades z-bug (Deprecated Label) z-p2 (Deprecated Label)
Projects
None yet
Development

No branches or pull requests

7 participants