This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Cleanups in the Keyring #5001
Merged
Cleanups in the Keyring #5001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
force-pushed
the
rav/keyring_cleanups
branch
3 times, most recently
from
4145b05 to
ee2c9ed
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5001 +/- ##
===========================================
- Coverage 61.51% 60.79% -0.73%
===========================================
Files 332 332
Lines 34227 34170 -57
Branches 5646 5630 -16
===========================================
- Hits 21056 20772 -284
- Misses 11661 11923 +262
+ Partials 1510 1475 -35 |
richvdh
force-pushed
the
rav/keyring_cleanups
branch
from
ee2c9ed to
f2004fb
Compare
Make this just return the key dict, rather than a single-entry dict mapping the server name to the key dict. It's easy for the caller to get the server name from from the response object anyway.
It's easier to check it in the caller than to complicate the interface with an extra param.
richvdh
force-pushed
the
rav/keyring_cleanups
branch
from
f2004fb to
b78aac5
Compare
Actually this isn't quite true. I think it will fix a bug in |
erikjohnston
approved these changes
Apr 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few miscellaneous refactors which don't achieve anything on their own, but I'd like to get off my stack.
Check the commits.