Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Collect room-version variations into one place #4969

Merged
merged 1 commit into from
Apr 1, 2019

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Mar 29, 2019

Collect all the things that make room-versions different to one another into
one place, so that it's easier to define new room versions.

Sorry about the size of this PR :/

Collect all the things that make room-versions different to one another into
one place, so that it's easier to define new room versions.
@richvdh richvdh requested a review from a team March 29, 2019 14:25
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit.

@codecov
Copy link

codecov bot commented Mar 29, 2019

Codecov Report

Merging #4969 into develop will increase coverage by 0.03%.
The diff coverage is 79.22%.

@@             Coverage Diff             @@
##           develop    #4969      +/-   ##
===========================================
+ Coverage    60.57%   60.61%   +0.03%     
===========================================
  Files          331      332       +1     
  Lines        34213    34235      +22     
  Branches      5655     5655              
===========================================
+ Hits         20723    20750      +27     
+ Misses       12012    12011       -1     
+ Partials      1478     1474       -4

@richvdh richvdh merged commit 54a87a7 into develop Apr 1, 2019
@richvdh richvdh deleted the rav/refactor_room_versions branch December 1, 2020 12:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants