This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix sync bug when accepting invites #4956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4956 +/- ##
==========================================
+ Coverage 60.57% 60.6% +0.03%
==========================================
Files 331 331
Lines 34213 34219 +6
Branches 5655 5657 +2
==========================================
+ Hits 20723 20738 +15
+ Misses 12015 12007 -8
+ Partials 1475 1474 -1 |
Hopefully this time we really will fix #4422. We need to make sure that the cache on `get_rooms_for_user_with_stream_ordering` is invalidated *before* the SyncHandler is notified for the new events, and we can now do so reliably via the `events` stream.
Fixes a race in the `get_rooms_for_user_with_stream_ordering` cache invalidation. Hopefully, won't break anything else.
richvdh
force-pushed
the
rav/sync_cache_bug_v3
branch
from
8660570 to
10027b6
Compare
erikjohnston
approved these changes
Apr 1, 2019
| self.get_rooms_for_user_with_stream_ordering.invalidate( | ||
| (data.state_key, ), | ||
| ) | ||
|
|
There was a problem hiding this comment.
Can we add an else clause that raises an exception please? Or at least logs loudly.
erikjohnston
approved these changes
Apr 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this time we really will fix #4422.
We need to make sure that the cache on
get_rooms_for_user_with_stream_orderingis invalidated before the SyncHandler is notified for the new events, and we can now do so reliably via theeventsstream.Based on #4955.