This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fixup shutdown room API #4904
Merged
Fixup shutdown room API #4904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a number of instances where a server or admin may puppet a user to join/leave rooms, which we don't want to fail if the user has not consented to the privacy policy. We fix this by adding a check to test if the requester has an associated access_token, which is used as a proxy to answer the question of whether the action is being done on behalf of a real request from the user.
Codecov Report
@@ Coverage Diff @@
## develop #4904 +/- ##
===========================================
- Coverage 59.85% 59.79% -0.06%
===========================================
Files 326 326
Lines 34025 34026 +1
Branches 5613 5612 -1
===========================================
- Hits 20366 20347 -19
- Misses 12235 12254 +19
- Partials 1424 1425 +1 |
Codecov Report
@@ Coverage Diff @@
## develop #4904 +/- ##
==========================================
- Coverage 77.94% 77.6% -0.34%
==========================================
Files 326 326
Lines 34025 34278 +253
Branches 5613 5716 +103
==========================================
+ Hits 26521 26603 +82
- Misses 5878 6033 +155
- Partials 1626 1642 +16 |
richvdh
reviewed
Mar 20, 2019
richvdh
reviewed
Mar 20, 2019
richvdh
reviewed
Mar 20, 2019
synapse/handlers/message.py
Outdated
| @@ -388,17 +391,6 @@ def assert_accepted_privacy_policy(self, requester): | |||
| if self._block_events_without_consent_error is None: | |||
| return | |||
|
|
|||
| # exempt AS users from needing consent | |||
There was a problem hiding this comment.
do we not still need this? is it covered by the is_exempt clause?
richvdh
approved these changes
Mar 21, 2019
tests/rest/client/v1/test_admin.py
Outdated
|
|
||
| other_user = self.register_user("user", "pass") | ||
| other_user_token = self.login("user", "pass") | ||
| def test_shutdown_room_conset(self): |
tests/rest/client/v1/test_admin.py
Outdated
|
|
||
| other_user = self.register_user("user", "pass") | ||
| other_user_token = self.login("user", "pass") | ||
| def test_shutdown_room_conset(self): |
There was a problem hiding this comment.
can you add a docstring that explains in slightly more words what you are testing for here?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.