This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add py27-old test case to buildkite #4879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
force-pushed
the
erikj/test_old_deps
branch
from
f87d3b0 to
b6ac5e4
Compare
richvdh
previously requested changes
Mar 18, 2019
Codecov Report
@@ Coverage Diff @@
## develop #4879 +/- ##
============================================
+ Coverage 59.59% 77.73% +18.14%
============================================
Files 326 326
Lines 33925 34107 +182
Branches 5597 5660 +63
============================================
+ Hits 20218 26514 +6296
+ Misses 12294 5965 -6329
- Partials 1413 1628 +215 |
Codecov Report
@@ Coverage Diff @@
## develop #4879 +/- ##
============================================
+ Coverage 59.59% 77.62% +18.03%
============================================
Files 326 326
Lines 33925 34617 +692
Branches 5597 5810 +213
============================================
+ Hits 20218 26873 +6655
+ Misses 12294 6088 -6206
- Partials 1413 1656 +243 |
richvdh
reviewed
Mar 19, 2019
tox.ini
Outdated
| commands = | ||
| /usr/bin/find "{toxinidir}" -name '*.pyc' -delete | ||
| # Make all greater-thans equals so we test the oldest version of our direct | ||
| # dependencies, but make the pyopenssl 17.0, which can work against an | ||
| # OpenSSL 1.1 compiled cryptography (as older ones don't compile on Travis). | ||
| /bin/sh -c 'python -m synapse.python_dependencies | sed -e "s/>=/==/g" -e "s/psycopg2==2.6//" -e "s/pyopenssl==16.0.0/pyopenssl==17.0.0/" | xargs pip install' | ||
| # Install Synapse itself. This won't update any libraries. |
| pip install -e . | ||
| {envbindir}/trial {env:TRIAL_FLAGS:} {posargs:tests} {env:TOXSUFFIX:} | ||
|
|
||
| {envbindir}/coverage run "{envbindir}/trial" {env:TRIAL_FLAGS:} {posargs:tests} {env:TOXSUFFIX:} |
There was a problem hiding this comment.
do we actually need to run the coverage checks here? is there any reason to imagine the coverage will be any different to the other runs?
There was a problem hiding this comment.
The same could be said for a lot of tests tbh, I'd rather we just consistently did coverage stats than have to figure out which tests do and which don't.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.