Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix yaml warnings by using safe_load #4869

Merged
merged 2 commits into from
Mar 22, 2019
Merged

Fix yaml warnings by using safe_load #4869

merged 2 commits into from
Mar 22, 2019

Conversation

erikjohnston
Copy link
Member

If you don't then it complains loudly to stderr. We can just use the
full loader as all of our yaml loading happens from trusted source (e.g.
config)

@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #4869 into develop will decrease coverage by 0.31%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           develop   #4869      +/-   ##
==========================================
- Coverage    78.01%   77.7%   -0.32%     
==========================================
  Files          326     326              
  Lines        34058   34341     +283     
  Branches      5621    5660      +39     
==========================================
+ Hits         26572   26683     +111     
- Misses        5867    6025     +158     
- Partials      1619    1633      +14

@hawkowl
Copy link
Contributor

hawkowl commented Mar 19, 2019

@erikjohnston is there any reason why we can't just use load_safe?

@erikjohnston
Copy link
Member Author

Probably not, I was just hoping to avoid having to think about it. Though given this doesn't work with old pyyaml that's probably the way to go

@erikjohnston erikjohnston requested a review from a team March 22, 2019 10:44
@erikjohnston erikjohnston changed the title Yaml library wants Loader to be defined Fix yaml warnings by using safe_load Mar 22, 2019
@erikjohnston
Copy link
Member Author

I've updated this to now use safe_load

@erikjohnston erikjohnston merged commit 5fee9d8 into develop Mar 22, 2019
@erikjohnston erikjohnston deleted the erikj/yaml_load branch January 9, 2020 15:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants