Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add some debug logging for device list handling #4828

Merged
merged 2 commits into from
Mar 7, 2019

Conversation

erikjohnston
Copy link
Member

In attempt to track down #4827

@erikjohnston erikjohnston requested a review from a team March 7, 2019 16:00
@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #4828 into develop will decrease coverage by 0.02%.
The diff coverage is 83.33%.

@@             Coverage Diff             @@
##           develop    #4828      +/-   ##
===========================================
- Coverage    75.33%   75.31%   -0.03%     
===========================================
  Files          340      340              
  Lines        34878    34888      +10     
  Branches      5705     5708       +3     
===========================================
  Hits         26276    26276              
- Misses        6991     7001      +10     
  Partials      1611     1611

@erikjohnston erikjohnston marked this pull request as ready for review March 7, 2019 16:16
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks plausible. Are you planning to remove any of this when you are done? Comments might help us find them if so.

@erikjohnston
Copy link
Member Author

Are you planning to remove any of this when you are done? Comments might help us find them if so.

I don't really see much reason to do so tbh, I doubt this will be the last time we want to debug device lists.

@erikjohnston erikjohnston merged commit 436b1c8 into develop Mar 7, 2019
@erikjohnston erikjohnston deleted the erikj/debug_device_lists branch January 9, 2020 15:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants