This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add ratelimiting on login #4821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4821 +/- ##
===========================================
- Coverage 75.18% 58.78% -16.4%
===========================================
Files 340 324 -16
Lines 34984 33849 -1135
Branches 5739 5590 -149
===========================================
- Hits 26303 19899 -6404
- Misses 7062 12571 +5509
+ Partials 1619 1379 -240 |
erikjohnston
previously requested changes
Mar 11, 2019
richvdh
previously requested changes
Mar 11, 2019
richvdh
previously requested changes
Mar 15, 2019
synapse/handlers/auth.py
Outdated
| @@ -569,6 +574,12 @@ def check_user_exists(self, user_id): | |||
| defer.Deferred: (unicode) canonical_user_id, or None if zero or | |||
| multiple matches | |||
| """ | |||
| self._account_ratelimiter.ratelimit( | |||
| user_id, time_now_s=self._clock.time(), | |||
| rate_hz=self.hs.config.rc_login.account.per_second, | |||
There was a problem hiding this comment.
can you pull out these config settings in the constructor please?
There was a problem hiding this comment.
Nope, because it makes the tests fail, since the test define special config parameters after initiating the handlers and servlets.
I had them in the constructor initially but couldn't find a sensible way to make the tests pass that way so I reverted that part.
richvdh
approved these changes
Mar 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two ratelimiters on login (per-IP address and per-userID).
Fixes #1452