Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Port #4422 debug logging from hotfixes #4816

Merged
merged 2 commits into from
Mar 6, 2019
Merged

Conversation

erikjohnston
Copy link
Member

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file
  • Pull request includes a sign off

@erikjohnston erikjohnston marked this pull request as ready for review March 6, 2019 17:32
@erikjohnston erikjohnston requested a review from a team March 6, 2019 17:33
@codecov
Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #4816 into develop will decrease coverage by 0.02%.
The diff coverage is 94.44%.

@@             Coverage Diff             @@
##           develop    #4816      +/-   ##
===========================================
- Coverage    75.17%   75.15%   -0.03%     
===========================================
  Files          340      340              
  Lines        34967    34983      +16     
  Branches      5733     5739       +6     
===========================================
+ Hits         26286    26290       +4     
- Misses        7065     7075      +10     
- Partials      1616     1618       +2

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@erikjohnston erikjohnston merged commit c665b63 into develop Mar 6, 2019
richvdh added a commit that referenced this pull request Apr 2, 2019
The relevant patches are now in develop thanks to
#4816.
@erikjohnston erikjohnston deleted the erikj/4422_debug branch January 9, 2020 15:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants