This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix parsing of Content-Disposition headers #4763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TIL: filenames in content-dispostion headers can contain semicolons, and aren't %-encoded.
erikjohnston
approved these changes
Feb 27, 2019
| """Parse a Content-type like header. | ||
|
|
||
| Cargo-culted from `cgi`, but works on bytes rather than strings. | ||
| """ |
Codecov Report
@@ Coverage Diff @@
## develop #4763 +/- ##
===========================================
+ Coverage 75.08% 75.12% +0.03%
===========================================
Files 340 340
Lines 34900 34918 +18
Branches 5719 5722 +3
===========================================
+ Hits 26204 26231 +27
+ Misses 7084 7074 -10
- Partials 1612 1613 +1 |
…sposition_parsing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TIL: filenames in content-dispostion headers can contain semicolons, and aren't %-encoded.