Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Test against Postgres 9.5 as well as 9.4 #4676

Merged
merged 1 commit into from
Feb 19, 2019
Merged

Test against Postgres 9.5 as well as 9.4 #4676

merged 1 commit into from
Feb 19, 2019

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Feb 19, 2019

Postgres 9.5 is the first to support UPSERTs, so we should really run against
it as well as 9.4.

Postgres 9.5 is the first to support UPSERTs, so we should really run against
it as well as 9.4.
@richvdh richvdh requested a review from a team February 19, 2019 09:55
@codecov-io
Copy link

Codecov Report

Merging #4676 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4676      +/-   ##
===========================================
+ Coverage    75.17%   75.19%   +0.01%     
===========================================
  Files          340      340              
  Lines        34712    34712              
  Branches      5677     5677              
===========================================
+ Hits         26096    26101       +5     
+ Misses        7013     7008       -5     
  Partials      1603     1603

@erikjohnston
Copy link
Member

I would be sorely tempted to only test pg9.4 on py2.7 and a later postgres on 3.6, but meh.

Do we want to test py3.7 instead of 3.6?

@richvdh
Copy link
Member Author

richvdh commented Feb 19, 2019

I would be sorely tempted to only test pg9.4 on py2.7 and a later postgres on 3.6, but meh.

maybe... we can always change it later I guess.

Do we want to test py3.7 instead of 3.6?

probably, but it's slightly non-trivial. Will make it a separate PR.

@richvdh richvdh merged commit 1c0eb8b into develop Feb 19, 2019
@richvdh richvdh deleted the rav/pg95 branch February 20, 2019 11:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants