Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Avoid redundant URL encoding #4555

Merged
merged 2 commits into from
Apr 4, 2019
Merged

Conversation

zauguin
Copy link
Contributor

@zauguin zauguin commented Feb 4, 2019

The redirect URL for SSO logins is transmitted using a HTML form field, therefore the browser takes care of proper URL encoding. We should therefore not encode the value because otherwise the redirect URL is "double-encoded" and no longer usable.

This fixes a regression introduced by #4220.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file
  • Pull request includes a sign off

Signed-off-by: Marcel Fabian Krüger <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #4555 into develop will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4555      +/-   ##
===========================================
+ Coverage     74.9%   74.91%   +<.01%     
===========================================
  Files          338      338              
  Lines        34509    34509              
  Branches      5620     5620              
===========================================
+ Hits         25850    25852       +2     
  Misses        7075     7075              
+ Partials      1584     1582       -2

@erikjohnston
Copy link
Member

@richvdh does this look plausible, given you touched it last?

@richvdh
Copy link
Member

richvdh commented Apr 4, 2019

yes, yes it does.

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@richvdh richvdh merged commit 9f5d206 into matrix-org:develop Apr 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants