This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Treat an invalid .well-known the same as an absent one #4544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... basically, carry on and fall back to SRV etc.
Codecov Report
@@ Coverage Diff @@
## release-v0.99.0 #4544 +/- ##
===================================================
- Coverage 74.87% 74.46% -0.41%
===================================================
Files 338 338
Lines 34504 35087 +583
Branches 5620 5789 +169
===================================================
+ Hits 25835 26128 +293
- Misses 7086 7347 +261
- Partials 1583 1612 +29 |
|
nobody seems to be about to review PRs :/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... basically, carry on and fall back to SRV etc.
Turns out a bunch of people return 200s to .well-known requests, but don't serve up valid .well-knowns