This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Enable support for room version 3 #4515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
force-pushed
the
erikj/room_version_v3
branch
from
126ab94 to
18723db
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4515 +/- ##
===========================================
+ Coverage 74.69% 74.72% +0.02%
===========================================
Files 336 336
Lines 34288 34293 +5
Branches 5590 5592 +2
===========================================
+ Hits 25611 25625 +14
+ Misses 7092 7080 -12
- Partials 1585 1588 +3 |
erikjohnston
force-pushed
the
erikj/room_version_v3
branch
from
c82ef4b to
ebcffbc
Compare
richvdh
approved these changes
Jan 29, 2019
| @@ -274,7 +274,10 @@ def _check_sigs_on_pdus(keyring, room_version, pdus): | |||
| # now let's look for events where the sender's domain is different to the | |||
| # event id's domain (normally only the case for joins/leaves), and add additional | |||
| # checks. Only do this if the room version has a concept of event ID domain | |||
| if room_version in KNOWN_ROOM_VERSIONS: | |||
| if room_version in ( | |||
| RoomVersions.V1, RoomVersions.V2, RoomVersions.VDH_TEST, | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #4499, #4514 and #4483