This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Refactoring in MatrixFederationAgent #4488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #4488 +/- ##
===========================================
+ Coverage 74.71% 74.73% +0.01%
===========================================
Files 336 336
Lines 34099 34122 +23
Branches 5544 5547 +3
===========================================
+ Hits 25477 25501 +24
+ Misses 7048 7047 -1
Partials 1574 1574 |
erikjohnston
approved these changes
Jan 28, 2019
|
|
||
| @attr.s | ||
| class _RoutingResult(object): | ||
| host_header = attr.ib() |
There was a problem hiding this comment.
A docstring would be good here. Specifically how this interacts with SRV records returning multiple answers; this seems to be a possible route, rather than all possible routes.
This is going to get too big and unmanageable.
We don't want to be doing .well-known lookups on these guys.
richvdh
force-pushed
the
rav/fed_routing/refactor
branch
from
82b833e to
ff05ad1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the routing out and handle IP literals separately.