Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix UPSERTs on SQLite 3.24+ #4477

Merged
merged 7 commits into from
Jan 28, 2019
Merged

Fix UPSERTs on SQLite 3.24+ #4477

merged 7 commits into from
Jan 28, 2019

Conversation

hawkowl
Copy link
Contributor

@hawkowl hawkowl commented Jan 25, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 25, 2019

Codecov Report

Merging #4477 into develop will decrease coverage by 0.01%.
The diff coverage is 77.77%.

@@             Coverage Diff             @@
##           develop    #4477      +/-   ##
===========================================
- Coverage    74.73%   74.71%   -0.02%     
===========================================
  Files          336      336              
  Lines        34122    34125       +3     
  Branches      5547     5548       +1     
===========================================
- Hits         25500    25498       -2     
- Misses        7048     7049       +1     
- Partials      1574     1578       +4

@erikjohnston
Copy link
Member

We will need to revert #4471 before merging this

@hawkowl hawkowl requested a review from erikjohnston January 28, 2019 14:36
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo adding a comment (as discussed IRL)

@hawkowl hawkowl merged commit 7072fe3 into develop Jan 28, 2019
@hawkowl hawkowl deleted the hawkowl/fix-upserts-2 branch January 28, 2019 15:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants