This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
debian package: symlink to python-3.X #4433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the debian package, make the virtualenv symlink python to /usr/bin/python3.X rather than /usr/bin/python3. Also make sure we depend on the right python3.x package. This might help a bit with subtle failures when people install a package from the wrong distro (#4431).
Codecov Report
@@ Coverage Diff @@
## develop #4433 +/- ##
========================================
Coverage 73.68% 73.68%
========================================
Files 300 300
Lines 29703 29703
Branches 4882 4882
========================================
Hits 21887 21887
- Misses 6386 6387 +1
+ Partials 1430 1429 -1 |
|
My only concern is that if people upgrade/replace their python version things will break? But from the bug it sounds like that would break already? |
Yes it would. Better to make the dependency explicit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the debian package, make the virtualenv symlink python to /usr/bin/python3.X rather than /usr/bin/python3. Also make sure we depend on the right python3.x package.
This might help a bit with subtle failures when people install a package from the wrong distro (#4431).
(aside: this stuff really ought to go into the debian changelog, rather than the main changelog. how hard would it be to make the CI check if
debian/changelogis updated when thedebiandirectory is updated, instead ofchangelog.d?)