This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Refactor and bugfix for resove_service #4427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful outside endpoints.
use an attrs instead of a namedtuple for resolve_service
I don't know why this needs to be nested so deep.
Codecov Report
@@ Coverage Diff @@
## develop #4427 +/- ##
===========================================
+ Coverage 73.64% 73.67% +0.02%
===========================================
Files 300 301 +1
Lines 29801 29812 +11
Branches 4896 4898 +2
===========================================
+ Hits 21947 21963 +16
+ Misses 6417 6411 -6
- Partials 1437 1438 +1 |
hawkowl
approved these changes
Jan 22, 2019
There was a problem hiding this comment.
Looks reasonable.
The coverage is a bit spotty, I would like some tests covering the yellow in srv_resolver if that's possible: https://codecov.io/gh/matrix-org/synapse/pull/4427/diff
Fair. will add some more testing. |
this should be a bytes, not a str.
hawkowl
approved these changes
Jan 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has several commits, each of which should make sense on its own.