Update README to use new virtualenv (#4328)

[aaronraimist]

Pull Request Checklist

• Pull request is based on the develop branch
• Pull request includes a changelog file
• Pull request includes a sign off

Fixes #4328

Should I also update the password reset section to assume you installed Synapse via pypi, so the location of hash_password would be ./env/bin/hash_password instead of ./scripts/hash_password?

[codecov-io]

Codecov Report

Merging #4342 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4342      +/-   ##
===========================================
+ Coverage    73.73%   73.75%   +0.01%     
===========================================
  Files          300      300              
  Lines        29751    29751              
  Branches      4878     4878              
===========================================
+ Hits         21938    21942       +4     
+ Misses        6387     6386       -1     
+ Partials      1426     1423       -3

Impacted Files	Coverage Δ
synapse/handlers/search.py	80.24% <0%> (ø)	⬆️
synapse/handlers/federation.py	61.72% <0%> (ø)	⬆️
synapse/util/logcontext.py	90.78% <0%> (+1.75%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7843f4...dd3bf40. Read the comment docs.

[aaronraimist]

Should I also update the password reset section to assume you installed Synapse via pypi, so the location of hash_password would be ./env/bin/hash_password instead of ./scripts/hash_password?

Or maybe it should just be changed to show how to use the admin api https://github.com/matrix-org/synapse/blob/master/docs/admin_api/user_admin_api.rst#reset-password

[richvdh]

Should I also update the password reset section to assume you installed Synapse via pypi, so the location of hash_password would be ./env/bin/hash_password instead of ./scripts/hash_password?

Yes, I think this needs updating. Note that just hash_password works from inside the virtualenv; also that it doesn't matter if you got synapse from pypi or git.

Or maybe it should just be changed to show how to use the admin api https://github.com/matrix-org/synapse/blob/master/docs/admin_api/user_admin_api.rst#reset-password

Well, that requires an admin user, which is a whole extra level of complication, so I'd stick with the script and sql.

[richvdh]

thanks!

[richvdh]

Yes, I think this needs updating.

just did this, since it was trivial