This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix UnicodeDecodeError when postgres is not configured in english #4253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit of a half-assed effort at fixing #4252. Fundamentally the right answer is to drop support for Python 2.
richvdh
force-pushed
the
rav/fix_postgres_unicode_issue
branch
from
8fe7c7a to
4ddcd4d
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4253 +/- ##
===========================================
- Coverage 73.55% 73.55% -0.01%
===========================================
Files 299 299
Lines 29806 29820 +14
Branches 4872 4876 +4
===========================================
+ Hits 21923 21933 +10
Misses 6456 6456
- Partials 1427 1431 +4
Continue to review full report at Codecov.
|
fix typo
erikjohnston
reviewed
Dec 4, 2018
synapse/util/stringutils.py
Outdated
| elif len(e.args) > 1: | ||
| return six.text_type(repr(e.args)) | ||
|
|
||
| msg = e.args |
There was a problem hiding this comment.
Do you mean msg = e.args[0]?
erikjohnston
approved these changes
Dec 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is actually a bit of a half-assed effort at fixing #4252. Having spent far too long staring at this and wondering what to do, I'm forced to the conclusion that the right answer is just to drop support for python 2, which appears to be completely broken when it comes to unicode in exception descriptions.
In the meantime, I hope this will make things slightly better.