Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Run the AS senders as background processes #4189

Merged
merged 2 commits into from
Dec 4, 2018

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Nov 15, 2018

This should fix some "Starting db connection from sentinel context" warnings, and will mean we get metrics for these processes.

This should fix some "Starting db connection from sentinel context" warnings,
and will mean we get metrics for these processes.
@richvdh richvdh requested a review from a team November 15, 2018 11:33
@richvdh
Copy link
Member Author

richvdh commented Nov 21, 2018

Hopefully the test failures will get fixed by #4209 or #4213 or something

@codecov-io
Copy link

Codecov Report

Merging #4189 into develop will increase coverage by 6.89%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4189      +/-   ##
===========================================
+ Coverage    66.65%   73.55%   +6.89%     
===========================================
  Files          299      299              
  Lines        29798    29808      +10     
  Branches      4871     4872       +1     
===========================================
+ Hits         19863    21926    +2063     
+ Misses        8501     6455    -2046     
+ Partials      1434     1427       -7
Impacted Files Coverage Δ
synapse/appservice/scheduler.py 86.71% <100%> (+30.36%) ⬆️
synapse/handlers/federation.py 61.72% <0%> (+0.1%) ⬆️
synapse/handlers/user_directory.py 71.03% <0%> (+0.3%) ⬆️
synapse/app/homeserver.py 57.28% <0%> (+0.33%) ⬆️
synapse/handlers/sync.py 92.05% <0%> (+0.44%) ⬆️
synapse/rest/client/v1/room.py 92.75% <0%> (+0.5%) ⬆️
synapse/rest/client/v1/presence.py 65.95% <0%> (+1.06%) ⬆️
synapse/push/httppusher.py 68.23% <0%> (+1.17%) ⬆️
synapse/handlers/directory.py 73.12% <0%> (+1.25%) ⬆️
synapse/handlers/profile.py 54.6% <0%> (+1.31%) ⬆️
... and 109 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 944d524...2038a82. Read the comment docs.

@richvdh
Copy link
Member Author

richvdh commented Nov 28, 2018

yay, the test failures went away.

@richvdh
Copy link
Member Author

richvdh commented Nov 28, 2018

[I'm not entirely sure why codecov thinks I've changed 119 files]

@richvdh richvdh merged commit 52e87fb into develop Dec 4, 2018
@richvdh richvdh deleted the rav/run_as_recoverer_in_background branch December 4, 2018 09:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants