Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Third Party Lookups: the returned protocol instance icons are not Matrix Content URIs #4175

Open
Tracked by #3506
giomfo opened this issue Nov 12, 2018 · 2 comments
Open
Tracked by #3506
Labels
A-Spec-Compliance places where synapse does not conform to the spec good first issue Good for newcomers S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@giomfo
Copy link
Member

giomfo commented Nov 12, 2018

Contrary to the documentation (https://matrix.org/docs/spec/client_server/r0.4.0.html#get-matrix-client-r0-thirdparty-protocols), the returned protocol icons are not mxc:// URIs.
The client gets https URLs (like "https://matrix.org/_matrix/media/v1/download/matrix.org/DHLHpDDgWNNejFmrewvwEAHX").

@giomfo giomfo added the z-bug (Deprecated Label) label Nov 12, 2018
@giomfo
Copy link
Member Author

giomfo commented Nov 12, 2018

Note: The documentation is correct here, the server should not return non-mxc content URLs

@clokep clokep added the A-Spec-Compliance places where synapse does not conform to the spec label Apr 29, 2020
@clokep clokep added S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. good first issue Good for newcomers and removed z-bug (Deprecated Label) labels Feb 24, 2021
@lukasdenk
Copy link
Contributor

Contrary to the documentation (https://matrix.org/docs/spec/client_server/r0.4.0.html#get-matrix-client-r0-thirdparty-protocols), the returned protocol icons are not mxc:// URIs.

@giomfo I cannot see where the docs specify the URI protocol of a returned icon link. The only information that I was able to find there about the icon parameter is the following:

Parameter Type Description
... ... ...
icon string Required. A content URI representing an icon for the third party protocol.

Also, I could not find anything in the current docs. The text passage closest to it is this one.

Can you specify, where the docs say that icon URIs should only be of protocol mxc?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Spec-Compliance places where synapse does not conform to the spec good first issue Good for newcomers S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Development

No branches or pull requests

3 participants