Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

consent fails under py3 #4136

Closed
richvdh opened this issue Nov 2, 2018 · 3 comments
Closed

consent fails under py3 #4136

richvdh opened this issue Nov 2, 2018 · 3 comments
Assignees

Comments

@richvdh
Copy link
Member

richvdh commented Nov 2, 2018

  File "/home/matrix/.synapse-py3/lib/python3.6/site-packages/twisted/internet/defer.py", line 1418, in _inlineCallbacks
    result = g.send(result)
  File "/home/matrix/synapse/synapse/rest/consent/consent_resource.py", line 148, in _async_render_GET
    self._check_hash(username, userhmac)
  File "/home/matrix/synapse/synapse/rest/consent/consent_resource.py", line 232, in _check_hash
    if not compare_digest(want_mac, userhmac):
builtins.TypeError: a bytes-like object is required, not 'str'
@hawkowl
Copy link
Contributor

hawkowl commented Nov 5, 2018

fixed by #4140

@hawkowl
Copy link
Contributor

hawkowl commented Nov 5, 2018

This can be closed when it's deployed to prod and proved working.

@richvdh
Copy link
Member Author

richvdh commented Nov 8, 2018

It still failed, but #4163 includes the fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants