This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
fix race condiftion in calling initialise_reserved_users #4081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
suggested changes
Oct 23, 2018
richvdh
reviewed
Oct 23, 2018
richvdh
approved these changes
Oct 25, 2018
| user_id (str): user to add/update | ||
| """ | ||
| is_insert = yield self.runInteraction( | ||
| "upsert_monthly_active_user", self.upsert_monthly_active_user_txn, | ||
| user_id | ||
| ) | ||
| # Considered pushing cache invalidation down into txn method, but |
There was a problem hiding this comment.
sorry, this isn't terribly easy to read; and I think it's actually more important to put something in the _txn method. How about getting rid of this, and instead, putting the following in the docstring of the _txn method:
Note that, after calling this method, it will generally be necessary to invalidate the caches on
user_last_seen_monthly_activeandget_monthly_active_count. We can't do that here, because we are running in a database thread rather than the main thread, and we can't calltxn.call_afterbecausetxnmay not be aLoggingTransaction.
richvdh
approved these changes
Oct 25, 2018
|
|
||
| def upsert_monthly_active_user_txn(self, txn, user_id): | ||
| """Updates or inserts monthly active user member | ||
| Note that, after calling this method, it will generally be necessary |
There was a problem hiding this comment.
Suggest an extra blank line here:
Suggested change
| Note that, after calling this method, it will generally be necessary | |
| Note that, after calling this method, it will generally be necessary |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.