This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Correctly account for cpu usage by background threads #4074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap calls to deferToThread() in a thing which uses a child logcontext to attribute CPU usage to the right request. While we're in the area, remove the logcontext_tracer stuff, which is never used, and afaik doesn't work. Fixes #4064
|
looks like this breaks things :/ |
erikjohnston
suggested changes
Oct 23, 2018
There was a problem hiding this comment.
Can we do something to reduce the boiler plate? It makes it hard to follow if everything starts with self.hs.get_reactor(), self.hs.get_reactor().getThreadPool(). Could we maybe make defer_to_threadpool take a hs object? Or even just the reactor and call getThreadPool() on it inside the function?
Otherwise looks good.
add another wrapper which removes the getThreadPool boilerplate
|
fair point. ptal. |
erikjohnston
approved these changes
Oct 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap calls to deferToThread() in a thing which uses a child logcontext to
attribute CPU usage to the right request.
While we're in the area, remove the logcontext_tracer stuff, which is never
used, and afaik doesn't work.
Fixes #4064