This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Clean up room alias creation #4063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, this also pulls in the change from using |
richvdh
approved these changes
Oct 24, 2018
| # association creation for app services | ||
| yield self._create_association(room_alias, room_id, servers) | ||
| yield self._create_association(room_alias, room_id, servers, creator=user_id) | ||
| if send_event: |
There was a problem hiding this comment.
I'm not entirely convinced that having this in here is helpful, but whatever
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, instead of trying to create the alias as a user and if that fails attempting to create as an appservice, we check if the requester is an appservice up front.