Run our oldest supported configuration in CI #3952
Conversation
…dentity is 16.0+ in all supported distros. pysaml3.0.0 doesn't expose it in the __version__, but we can trust the package managers here.
| @@ -64,6 +64,25 @@ setenv = | |||
| {[base]setenv} | |||
| SYNAPSE_POSTGRES = 1 | |||
|
|
|||
| [testenv:py27-old] | |||
There was a problem hiding this comment.
doesn't this need listing under envlist ?
There was a problem hiding this comment.
The envlist is just what's run on tox with no args, so I guess not?
tox.ini
Outdated
| /usr/bin/find "{toxinidir}" -name '*.pyc' -delete | ||
| /bin/sh -c 'python -m synapse.python_dependencies | sed -e "s/>=/==/g" | sed -e "s/psycopg2==2.6/psycopg2==2.7/" | sed -e "s/pyopenssl==16.0.0/pyopenssl==17.0.0/" | xargs pip install' | ||
| pip install -e . | ||
| coverage run {env:COVERAGE_OPTS:} --source="{toxinidir}/synapse" \ |
There was a problem hiding this comment.
I wonder if we really care about the coverage here.
tox.ini
Outdated
| lxml | ||
| commands = | ||
| /usr/bin/find "{toxinidir}" -name '*.pyc' -delete | ||
| /bin/sh -c 'python -m synapse.python_dependencies | sed -e "s/>=/==/g" | sed -e "s/psycopg2==2.6/psycopg2==2.7/" | sed -e "s/pyopenssl==16.0.0/pyopenssl==17.0.0/" | xargs pip install' |
There was a problem hiding this comment.
could you add some comments explaining the exceptions?
tox.ini
Outdated
| lxml | ||
| commands = | ||
| /usr/bin/find "{toxinidir}" -name '*.pyc' -delete | ||
| /bin/sh -c 'python -m synapse.python_dependencies | sed -e "s/>=/==/g" | sed -e "s/psycopg2==2.6/psycopg2==2.7/" | sed -e "s/pyopenssl==16.0.0/pyopenssl==17.0.0/" | xargs pip install' |
There was a problem hiding this comment.
suggest one sed with multiple -es rather than multiple seds
| @@ -64,6 +64,25 @@ setenv = | |||
| {[base]setenv} | |||
| SYNAPSE_POSTGRES = 1 | |||
|
|
|||
| [testenv:py27-old] | |||
There was a problem hiding this comment.
could you add a comment explaining what this env does (and why)?
tox.ini
Outdated
| commands = | ||
| /usr/bin/find "{toxinidir}" -name '*.pyc' -delete | ||
| # Make all greater-thans equals, as well as update psycopg2 and pyopenssl | ||
| # versions to older versions which still compile on current versions of |
There was a problem hiding this comment.
s/older/newer/?
Could you give more specific examples? which OSes do these libs not compile on? (Travis runs on a pretty ancient os (ubuntu 14.04 ?), so I'd be surprised if there were things which we needed to support for xenial which don't compile on there)
tox.ini
Outdated
| commands = | ||
| /usr/bin/find "{toxinidir}" -name '*.pyc' -delete | ||
| # Make all greater-thans equals so we test the oldest version of our direct | ||
| # dependencies, but make the psycopg2 version one which can compile against |
There was a problem hiding this comment.
I still think we're going to stare at this in a month's time and try to remember the history here. Could you put
"although we support psycopg2 2.6 (because that's what's in xenial), the Travis build images use postgres 10, which is incompatible with 2.6, so we make 2.7 our minimum. Similarly, blah blah pyopenssl".
tox.ini
Outdated
| # dependencies, but make the psycopg2 version one which can compile against | ||
| # PostgreSQL 10 and the pyopenssl one which can work against an OpenSSL 1.1 | ||
| # compiled cryptography. | ||
| /bin/sh -c 'python -m synapse.python_dependencies | sed -e "s/>=/==/g" -e "s/psycopg2==2.6/psycopg2==2.7/" -e "s/pyopenssl==16.0.0/pyopenssl==17.0.0/" | xargs pip install' |
There was a problem hiding this comment.
[given we're not running the tests against postgres here, why do we care about psycopg2 at all?]
There was a problem hiding this comment.
I guess we could just remove it entirely, yeah.
No description provided.