Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix userconsent on Python 3 #3938

Merged
merged 14 commits into from
Oct 1, 2018
Merged

Fix userconsent on Python 3 #3938

merged 14 commits into from
Oct 1, 2018

Conversation

hawkowl
Copy link
Contributor

@hawkowl hawkowl commented Sep 24, 2018

No description provided.

@hawkowl hawkowl requested a review from a team September 28, 2018 14:36
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

def default_config(self, name="test"):
"""
Get a default HomeServer config object.
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you document what name is naming?

@hawkowl hawkowl merged commit 6e05fd0 into develop Oct 1, 2018
@hawkowl hawkowl deleted the hawkowl/py3-userconsent branch October 1, 2018 14:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants