This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix database port script to work with new event_search table #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -229,19 +230,51 @@ class Porter(object): | |||
| if rows: | |||
| next_chunk = rows[-1][0] + 1 | |||
|
|
|||
| self._convert_rows(table, headers, rows) | |||
| if table == "event_search": | |||
| # We have to treat event_search differnetly since it has a | |||
There was a problem hiding this comment.
spelling differently
|
LGTM other than the spelling. I wonder if it would be simpler to leave it to a background update task like the schema update script does. |
|
@NegativeMjark I thought about that, but then I concluded it would be simpler and easier to understand to just port all the data across; otherwise I would have to start fiddling with the actual data to ensure it was all consistent, etc. |
|
LGTM |
erikjohnston
added a commit
that referenced
this pull request
Nov 19, 2015
Fix database port script to work with new event_search table
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.