Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Some metric label values have changed in python3 #3861

Closed
erikjohnston opened this issue Sep 13, 2018 · 1 comment
Closed

Some metric label values have changed in python3 #3861

erikjohnston opened this issue Sep 13, 2018 · 1 comment
Assignees
@richvdh
Labels
A-Logging Synapse's logs (structured or otherwise). Not metrics.

Comments

@erikjohnston
Copy link
Member

For example, for synapse_http_server_response_ru_utime_seconds the method label now have values such as b'GET' where previously it was just GET
@hawkowl hawkowl added the py3 label Sep 13, 2018
@hawkowl hawkowl added the A-Logging Synapse's logs (structured or otherwise). Not metrics. label Sep 14, 2018
@richvdh
Copy link
Member

richvdh commented Sep 18, 2018

I think this was probably fixed by #3895 and #3892.

@richvdh richvdh mentioned this issue Sep 18, 2018
Merged
@richvdh richvdh self-assigned this Sep 18, 2018
@richvdh richvdh closed this as completed Sep 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@richvdh richvdh

Labels
A-Logging Synapse's logs (structured or otherwise). Not metrics.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@richvdh @hawkowl @erikjohnston