This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
don't return non-LL-member state in incremental sync state blocks #3760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ara4n
added a commit
to matrix-org/sytest
that referenced
this pull request
Aug 24, 2018
…hen LLing tests matrix-org/synapse#3760 regression test for element-hq/element-web#7223
|
@matrixbot retest this please |
richvdh
approved these changes
Aug 28, 2018
| @@ -747,7 +747,7 @@ def compute_state_delta(self, room_id, batch, sync_config, since_token, now_toke | |||
| if types: | |||
There was a problem hiding this comment.
I'm struggling to remember what this block is for (it's a shame there's no comment). AIUI, this is dealing with the situation that:
- We're returning an incremental sync, with no "gap" since the previous sync, so normally there would be no state to return
- But we're lazy-loading, so the client might need some more member events to understand the events in this timeline
- So we fish out all the member events corresponding to the timeline here, and then dedupe them below
Could you confirm and add a comment?
There was a problem hiding this comment.
confirmed; have added comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes element-hq/element-web#7223.
Tests over at matrix-org/sytest#487