This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix tests on postgresql #3740
Merged
Fix tests on postgresql #3740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
reviewed
Sep 2, 2018
| @@ -191,6 +190,7 @@ def user_last_seen_monthly_active(self, user_id): | |||
| allow_none=True, | |||
| desc="user_last_seen_monthly_active", | |||
| )) | |||
| defer.returnValue(res) | |||
There was a problem hiding this comment.
What's the reason for converting all these functions to defer.inlineCallbacks?
There was a problem hiding this comment.
me trying things and inadvertently committing it :) -- reverted
erikjohnston
previously requested changes
Sep 3, 2018
synapse/storage/_base.py
Outdated
| ) | ||
| self.clock = self.hs.get_clock() | ||
| else: | ||
| self._cache_id_gen = None |
There was a problem hiding this comment.
So, fun fact: this now gets set on the slave replication stores as well as the store on master. This is a bit awkward because we do set self._cache_id_gen on the replication stores in synapse/replication/slave/storage/_base.py to something different.
In short, everything is awful and is scary and I'm scared about moving this here in case the replication stuff fail to properly overwrite this definition
erikjohnston
approved these changes
Sep 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.