This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Split out DB writes in federation handler #3621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to easily add an internal replication API to proxy these reqeusts to master, so that we can move federation APIs to workers.
richvdh
reviewed
Jul 31, 2018
synapse/storage/events.py
Outdated
| which might update the current state etc. | ||
|
|
||
| Returns: | ||
| Deferred[int]: he stream ordering of the latest persisted event |
| ) | ||
|
|
||
| defer.returnValue((event_stream_id, max_stream_id)) |
| @@ -1616,12 +1551,10 @@ def _persist_auth_tree(self, origin, auth_events, state, event): | |||
| event, old_state=state | |||
| ) | |||
|
|
|||
| event_stream_id, max_stream_id = yield self.store.persist_event( | |||
| event, new_event_context, | |||
| yield self._persist_events( | |||
There was a problem hiding this comment.
I'm struggling to keep track of which methods do the notification and which do not. Could you update the docstring on persist_auth_tree?
| @@ -1517,7 +1452,7 @@ def _handle_new_events(self, origin, event_infos, backfilled=False): | |||
| ], consumeErrors=True, | |||
| )) | |||
|
|
|||
| yield self.store.persist_events( | |||
| yield self._persist_events( | |||
There was a problem hiding this comment.
again, can you update the docstring to say that we may notify
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to easily add an internal replication API to proxy
these reqeusts to master, so that we can move federation APIs to
workers.