Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Make EventStore inherit from EventFederationStore #3612

Merged
merged 3 commits into from
Jul 31, 2018
Merged

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jul 26, 2018

(since it uses methods therein)

Turns out that we had a bunch of things which were incorrectly importing
EventWorkerStore from events.py rather than events_worker.py, which broke once
I removed the import into events.py.

richvdh added 2 commits July 26, 2018 12:48
(since it uses methods therein)

Turns out that we had a bunch of things which were incorrectly importing
EventWorkerStore from events.py rather than events_worker.py, which broke once
I removed the import into events.py.
@richvdh richvdh requested a review from a team July 26, 2018 17:36
class EventsStore(EventsWorkerStore):
# inherits from EventFederationStore so that we can call _update_backward_extremities
# and _handle_mult_prev_events (though arguably those could both be moved in here)
class EventsStore(EventFederationStore):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to remove the explicit include of EventsWorkerStore and rely on that EventFederationStore pulls in it? Personally I'd prefer to keep it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't mind really. I guess it makes sense to keep it explicit so we don't forget it's needed.

@richvdh richvdh requested a review from a team July 31, 2018 12:11
@richvdh richvdh merged commit 5de936c into develop Jul 31, 2018
@richvdh richvdh deleted the rav/store_heirarchy branch July 31, 2018 12:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants