Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

event contents with invalid utf-8 binary are accepted on synapse+sqlite #3537

Open
ara4n opened this issue Jul 15, 2018 · 3 comments
Open

event contents with invalid utf-8 binary are accepted on synapse+sqlite #3537

ara4n opened this issue Jul 15, 2018 · 3 comments
Labels
A-Spec-Compliance places where synapse does not conform to the spec S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. z-minor (Deprecated Label) z-p2 (Deprecated Label)

Comments

@ara4n
Copy link
Member

ara4n commented Jul 15, 2018

No description provided.

@ara4n ara4n changed the title anecdotal evidence that sending a contents with invalid utf-8 binary in it may be accepted to the db on synapse+sqlite anecdotal evidence that sending event contents with invalid utf-8 binary in it may be accepted to the db on synapse+sqlite Jul 15, 2018
@ara4n ara4n mentioned this issue Jul 15, 2018
Open
@ara4n
Copy link
Member Author

ara4n commented Jul 15, 2018

Specifically, this was sending ISO-8859-15 encoded characters into a room via API, at which point everything went wrong.

@neilisfragile neilisfragile added z-p2 (Deprecated Label) z-minor (Deprecated Label) labels Jul 23, 2018
@richvdh
Copy link
Member

richvdh commented Sep 6, 2018

this is basically a subset of https://github.com/matrix-org/matrix-doc/issues/1646

@richvdh
Copy link
Member

richvdh commented Sep 6, 2018

It sounds from matrix-org/matrix-spec#940 that the problem was less that the characters were ISO-8859-15 encoded, and more that when you happened to interpret them as UTF-8 instead you get the UTF-16 surrogates, which is invalid.

@richvdh richvdh changed the title anecdotal evidence that sending event contents with invalid utf-8 binary in it may be accepted to the db on synapse+sqlite event contents with invalid utf-8 binary are accepted on synapse+sqlite Feb 12, 2020
@reivilibre reivilibre added A-Spec-Compliance places where synapse does not conform to the spec S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. labels Mar 2, 2022
This was referenced Dec 21, 2023
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Spec-Compliance places where synapse does not conform to the spec S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. z-minor (Deprecated Label) z-p2 (Deprecated Label)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@neilisfragile @ara4n @richvdh @reivilibre