This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Reject invalid server names #3480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that server_names used in auth headers are sane, and reject them with a sensible error code, before they disappear off into the depths of the system.
erikjohnston
suggested changes
Jul 3, 2018
| 'localhost': ('localhost', None), | ||
| 'my-example.com:1234': ('my-example.com', 1234), | ||
| '1.2.3.4': ('1.2.3.4', None), | ||
| '[0abc:1def::1234]': ('[0abc:1def::1234]', None), |
There was a problem hiding this comment.
I'd quite like to see a couple of tests for IPv4 and IPv6 literals with ports specified; I don't think IPv6 literal with port works.
erikjohnston
approved these changes
Jul 3, 2018
missing NL
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that server_names used in auth headers are sane, and reject them with
a sensible error code, before they disappear off into the depths of the system.