This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Make sure that attr is installed #3356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've rcently added a dep on `attr`. I don't know why the CI didn't pick this up, but we should make it explicit anyway.
richvdh
changed the title
|
@richvdh likely because a bunch of current-versions of deps (Twisted, for example) depend on it transiently, so it wouldn't have shown up in CI which uses all the current versions. LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've rcently added a dep on
attr. I don't know why the CI didn't pick thisup, but we should make it explicit anyway.