Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix federation backfill from sqlite servers #3355

Merged
merged 1 commit into from
Jun 7, 2018

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jun 6, 2018

This fixes bug #3354.

If _get_state_groups_from_groups was called with a (type, None) entry in types (which is supposed to return all state of type type), it would explode with a sql error. I think this only happens for federation backfill.

I am deeply distressed that there is apparently no test coverage of this, but really can't afford to sort it out now :/

If this was called with a `(type, None)` entry in types (which is supposed to
return all state of type `type`), it would explode with a sql error.
@richvdh richvdh changed the title Fix sql error in _get_state_groups_from_groups Fix federation backfill from sqlite servers Jun 6, 2018
@hawkowl
Copy link
Contributor

hawkowl commented Jun 7, 2018

This looks correct-er than it was. 👍

@hawkowl hawkowl assigned richvdh and unassigned hawkowl Jun 7, 2018
@richvdh richvdh merged commit e2acf53 into develop Jun 7, 2018
@richvdh richvdh deleted the rav/fix_federation_backfill branch July 10, 2018 12:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants