This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Support for putting %(consent_uri)s in messages #3271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it possible to put the URI in the error message and the server notice that get sent by the server
erikjohnston
approved these changes
May 23, 2018
| self._server_notice_content, { | ||
| 'consent_uri': consent_uri, | ||
| }, | ||
| ) |
There was a problem hiding this comment.
I really don't like that the idea of magically going and rewriting everything like this, but am prepared to accept it for now since presumably we need the flexibility.
There was a problem hiding this comment.
yeah seems like flexibility ftw right now
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to put the URI in the error message and the server notice that
get sent by the server